Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate key pair via p2panda-js and store it locally #12

Closed
wants to merge 18 commits into from
Closed

Generate key pair via p2panda-js and store it locally #12

wants to merge 18 commits into from

Conversation

cafca
Copy link
Member

@cafca cafca commented Nov 13, 2020 •
edited by adzialocha
Loading

Todo:

  • Import p2panda-js package
  • Generate new key pair when it does not exist yet
  • Restore key pair when it already exists
  • Optional: Handle key pair in separate file which can be accessed globally (can be later improved with Higher-order component for p2panda state #14)

Steps to handle key pair:

  • Check if private key exists in localStorage
  • If it does not exist, generate new key pair via const keyPair = new KeyPair(), store it in localStorage
  • If it exists, restore key pair via const keyPair = KeyPair.fromPrivateKey(privateKey)

@cafca cafca mentioned this pull request Nov 15, 2020
Merged
cafca
cafca commented Nov 15, 2020
View reviewed changes
src/pages/Home.tsx Outdated Show resolved Hide resolved
cafca
cafca commented Nov 15, 2020
View reviewed changes
src/pages/Home.tsx Outdated Show resolved Hide resolved
@adzialocha adzialocha linked an issue Nov 16, 2020 that may be closed by this pull request
Generate and store key pair on first start #8
Closed
@adzialocha adzialocha changed the title Add experimental output from locally linked Sesamoid Generate key pair via Sesamoid and store it locally Nov 16, 2020
@cafca cafca linked an issue Jan 9, 2021 that may be closed by this pull request
Import p2panda-js #9
Closed
@cafca cafca changed the title Generate key pair via Sesamoid and store it locally Generate key pair via p2panda-js and store it locally Jan 9, 2021
@cafca
Copy link
Member Author

cafca commented Apr 10, 2021

We already implemented everything asked for here

@cafca cafca closed this Apr 10, 2021
@adzialocha adzialocha deleted the identity/generate-keypair branch May 17, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adzialocha adzialocha adzialocha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import p2panda-js Generate and store key pair on first start
3 participants
@cafca @adzialocha @sophiiistika